Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rapid router 1732 #1737

Merged
merged 14 commits into from
Oct 3, 2024
Merged

feat: Rapid router 1732 #1737

merged 14 commits into from
Oct 3, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Oct 2, 2024

This change is Reviewable

@SKairinos SKairinos changed the title Rapid router 1732 feat: Rapid router 1732 Oct 2, 2024
@SKairinos SKairinos linked an issue Oct 2, 2024 that may be closed by this pull request
9 tasks
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @SKairinos)


game/static/game/js/blockly/msg/js/bg.js line 464 at r1 (raw file):

Blockly.Msg["AT_DESTINATION_TITLE"] = "На адреса";
Blockly.Msg["COW_CROSSING_TITLE"] = "Крави";
Blockly.Msg["PIGEON_CROSSING_TITLE"] = "pigeons"; // untranslated

translate using Google Translate pls


game/static/game/js/blockly/msg/js/pl.js line 464 at r1 (raw file):

Blockly.Msg["AT_DESTINATION_TITLE"] = "U celu";
Blockly.Msg["COW_CROSSING_TITLE"] = "Krowy";
Blockly.Msg["PIGEON_CROSSING_TITLE"] = "pigeons"; // untranslated

translate using Google Translate pls


game/static/game/js/blockly/msg/js/pt-br.js line 464 at r1 (raw file):

Blockly.Msg["AT_DESTINATION_TITLE"] = "No destino";
Blockly.Msg["COW_CROSSING_TITLE"] = "Vacas";
Blockly.Msg["PIGEON_CROSSING_TITLE"] = "pigeons"; // untranslated

translate using Google Translate pls


game/static/game/js/blockly/msg/js/ru.js line 464 at r1 (raw file):

Blockly.Msg["AT_DESTINATION_TITLE"] = "В пункте назначения";
Blockly.Msg["COW_CROSSING_TITLE"] = "Коровы";
Blockly.Msg["PIGEON_CROSSING_TITLE"] = "pigeons"; // untranslated

translate using Google Translate pls

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @faucomte97)


game/static/game/js/blockly/msg/js/bg.js line 464 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

translate using Google Translate pls

Done.


game/static/game/js/blockly/msg/js/pl.js line 464 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

translate using Google Translate pls

Done.


game/static/game/js/blockly/msg/js/pt-br.js line 464 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

translate using Google Translate pls

Done.


game/static/game/js/blockly/msg/js/ru.js line 464 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

translate using Google Translate pls

Done.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @SKairinos)


game/static/game/js/blockly/msg/js/bg.js line 464 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

Done.

Very pedantic I know but can you capitalise the translations for pigeons? so it's consistent with the other blocks (especially the cow block)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit 8ac9fae into master Oct 3, 2024
5 checks passed
@SKairinos SKairinos deleted the rapid-router-1732 branch October 3, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reviewed translations to Rapid Router
2 participants